Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use webContents.create() in type-safe way #37308

Merged
merged 1 commit into from Feb 16, 2023
Merged

test: use webContents.create() in type-safe way #37308

merged 1 commit into from Feb 16, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 16, 2023

Backport of #37281

See that PR for details.

Notes: none

@trop
test: use (webContents as typeof ElectronInternal.WebContents).create()
6539460 
Co-authored-by: Milan Burda <miburda@microsoft.com>
@trop trop bot requested a review from miniak February 16, 2023 14:42
@trop trop bot mentioned this pull request Feb 16, 2023
Merged
3 tasks
@trop trop bot added 24-x-y backport This is a backport PR semver/none labels Feb 16, 2023
@deepak1556 deepak1556 merged commit 52adfe2 into 24-x-y Feb 16, 2023
@deepak1556 deepak1556 deleted the trop/24-x-y-bp-test-use-webcontents-create-in-type-safe-way-1676558518958 branch February 16, 2023 23:48
@release-clerk
Copy link

release-clerk bot commented Feb 16, 2023

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
24-x-y backport This is a backport PR semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@deepak1556